diff options
| author |   Josef Bacik <josef@toxicpanda.com> | 2021-03-12 15:25:12 -0500 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2021-04-19 17:25:20 +0200 |
| commit | 03a7e111a94961092e2832a6259d39c8c01d6def (patch) | |
| tree | b3af5a1804c4bd73be7190ce20d04c1d7eff144f /fs/btrfs/transaction.c | |
| parent | btrfs: handle record_root_in_trans failure in create_pending_snapshot (diff) | |
| download | linux-dev-03a7e111a94961092e2832a6259d39c8c01d6def.tar.xz linux-dev-03a7e111a94961092e2832a6259d39c8c01d6def.zip | |
btrfs: return an error from btrfs_record_root_in_trans
We can create a reloc root when we record the root in the trans, which
can fail for all sorts of different reasons. Propagate this error up
the chain of callers. Future patches will fix the callers of
btrfs_record_root_in_trans() to handle the error.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/transaction.c')
| -rw-r--r-- | fs/btrfs/transaction.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 461baad8760c..4e9e751c99fa 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -413,6 +413,7 @@ static int record_root_in_trans(struct btrfs_trans_handle *trans, int force) { struct btrfs_fs_info *fs_info = root->fs_info; + int ret = 0; if ((test_bit(BTRFS_ROOT_SHAREABLE, &root->state) && root->last_trans < trans->transid) || force) { @@ -461,11 +462,11 @@ static int record_root_in_trans(struct btrfs_trans_handle *trans, * lock. smp_wmb() makes sure that all the writes above are * done before we pop in the zero below */ - btrfs_init_reloc_root(trans, root); + ret = btrfs_init_reloc_root(trans, root); smp_mb__before_atomic(); clear_bit(BTRFS_ROOT_IN_TRANS_SETUP, &root->state); } - return 0; + return ret; } |