diff options
| author |   Josef Bacik <josef@toxicpanda.com> | 2020-12-18 14:24:25 -0500 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2021-02-08 22:58:57 +0100 |
| commit | dac348e9257051e7a39224747695b53e3fc737d7 (patch) | |
| tree | 6c83d55890e180146877a5ed3851d0bb468f4113 /fs/btrfs/transaction.c | |
| parent | btrfs: remove bogus BUG_ON in alloc_reserved_tree_block (diff) | |
| download | linux-dev-dac348e9257051e7a39224747695b53e3fc737d7.tar.xz linux-dev-dac348e9257051e7a39224747695b53e3fc737d7.zip | |
btrfs: stop running all delayed refs during snapshot
This was added in commit 361048f586f5 ("Btrfs: fix full backref problem
when inserting shared block reference") to address a problem where we
hit the following BUG_ON() in alloc_reserved_tree_block
if (node->type == BTRFS_SHARED_BLOCK_REF_KEY) {
BUG_ON(!(flags & BTRFS_BLOCK_FLAG_FULL_BACKREF));
However this BUG_ON() is bogus, and was removed by previous commit:
btrfs: remove bogus BUG_ON in alloc_reserved_tree_block
We no longer need to run delayed refs because of this, and can remove
this flushing here.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/transaction.c')
| -rw-r--r-- | fs/btrfs/transaction.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index dbbd46417534..02592c6ce755 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -1749,12 +1749,6 @@ static noinline int create_pending_snapshot(struct btrfs_trans_handle *trans, } } - ret = btrfs_run_delayed_refs(trans, (unsigned long)-1); - if (ret) { - btrfs_abort_transaction(trans, ret); - goto fail; - } - fail: pending->error = ret; dir_item_existed: |