diff options
| author |   Miao Xie <miaox@cn.fujitsu.com> | 2014-11-25 16:39:28 +0800 |
|---|---|---|
| committer | Miao Xie <miaox@cn.fujitsu.com> | 2014-12-03 10:18:47 +0800 |
| commit | 4245215d6a8dba1a51c50533b6667919687c0b89 (patch) | |
| tree | d3d988c61ff1dcf8fe6886e3c2ba3783814d614e /fs/btrfs/volumes.c | |
| parent | Btrfs, replace: write raid56 parity into the replace target device (diff) | |
| download | linux-dev-4245215d6a8dba1a51c50533b6667919687c0b89.tar.xz linux-dev-4245215d6a8dba1a51c50533b6667919687c0b89.zip | |
Btrfs, raid56: fix use-after-free problem in the final device replace procedure on raid56
The commit c404e0dc (Btrfs: fix use-after-free in the finishing
procedure of the device replace) fixed a use-after-free problem
which happened when removing the source device at the end of device
replace, but at that time, btrfs didn't support device replace
on raid56, so we didn't fix the problem on the raid56 profile.
Currently, we implemented device replace for raid56, so we need
kick that problem out before we enable that function for raid56.
The fix method is very simple, we just increase the bio per-cpu
counter before we submit a raid56 io, and decrease the counter
when the raid56 io ends.
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6d8a5e8d8c39..cbb766577f31 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -5843,12 +5843,9 @@ int btrfs_map_bio(struct btrfs_root *root, int rw, struct bio *bio, } else { ret = raid56_parity_recover(root, bio, bbio, raid_map, map_length, - mirror_num, 0); + mirror_num, 1); } - /* - * FIXME, replace dosen't support raid56 yet, please fix - * it in the future. - */ + btrfs_bio_counter_dec(root->fs_info); return ret; } |