diff options
| author |   Naohiro Aota <naohiro.aota@wdc.com> | 2020-02-25 12:56:07 +0900 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2020-03-23 17:01:48 +0100 |
| commit | b25c19f49ef294865462bf741e0430c59295ac15 (patch) | |
| tree | 509d733ec059d24f7838b291ee17ba229dbc2070 /fs/btrfs/volumes.c | |
| parent | btrfs: change full_search to bool in find_free_extent_update_loop (diff) | |
| download | linux-dev-b25c19f49ef294865462bf741e0430c59295ac15.tar.xz linux-dev-b25c19f49ef294865462bf741e0430c59295ac15.zip | |
btrfs: handle invalid profile in chunk allocation
Do not BUG_ON() when an invalid profile is passed to __btrfs_alloc_chunk().
Instead return -EINVAL with ASSERT() to catch a bug in the development
stage.
Suggested-by: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 3d35466f34b0..f1c98b01f6ec 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -4773,7 +4773,10 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans, int j; int index; - BUG_ON(!alloc_profile_is_valid(type, 0)); + if (!alloc_profile_is_valid(type, 0)) { + ASSERT(0); + return -EINVAL; + } if (list_empty(&fs_devices->alloc_list)) { if (btrfs_test_opt(info, ENOSPC_DEBUG)) |