aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/volumes.h
diff options
context:
space:
mode:
authorJosef Bacik <josef@toxicpanda.com>2020-01-21 09:17:06 -0500
committerDavid Sterba <dsterba@suse.com>2020-01-23 17:24:39 +0100
commit4e19443da1941050b346f8fc4c368aa68413bc88 (patch)
tree70816e547a25898f7e49e0d753edf6767235a796 /fs/btrfs/volumes.h
parentbtrfs: Fix split-brain handling when changing FSID to metadata uuid (diff)
downloadlinux-dev-4e19443da1941050b346f8fc4c368aa68413bc88.tar.xz
linux-dev-4e19443da1941050b346f8fc4c368aa68413bc88.zip
btrfs: free block groups after free'ing fs trees
Sometimes when running generic/475 we would trip the WARN_ON(cache->reserved) check when free'ing the block groups on umount. This is because sometimes we don't commit the transaction because of IO errors and thus do not cleanup the tree logs until at umount time. These blocks are still reserved until they are cleaned up, but they aren't cleaned up until _after_ we do the free block groups work. Fix this by moving the free after free'ing the fs roots, that way all of the tree logs are cleaned up and we have a properly cleaned fs. A bunch of loops of generic/475 confirmed this fixes the problem. CC: stable@vger.kernel.org # 4.9+ Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.h')
0 files changed, 0 insertions, 0 deletions