diff options
| author |   Josef Bacik <josef@toxicpanda.com> | 2020-02-13 10:47:28 -0500 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2020-02-19 00:36:35 +0100 |
| commit | 315bf8ef914f31d51d084af950703aa1e09a728c (patch) | |
| tree | 4d592990138af7d7b60144f63b47563ae8c52f39 /fs/btrfs | |
| parent | btrfs: destroy qgroup extent records on transaction abort (diff) | |
| download | linux-dev-315bf8ef914f31d51d084af950703aa1e09a728c.tar.xz linux-dev-315bf8ef914f31d51d084af950703aa1e09a728c.zip | |
btrfs: reset fs_root to NULL on error in open_ctree
While running my error injection script I hit a panic when we tried to
clean up the fs_root when freeing the fs_root. This is because
fs_info->fs_root == PTR_ERR(-EIO), which isn't great. Fix this by
setting fs_info->fs_root = NULL; if we fail to read the root.
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/disk-io.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index d7fec89974cb..197352f23534 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3200,6 +3200,7 @@ int __cold open_ctree(struct super_block *sb, if (IS_ERR(fs_info->fs_root)) { err = PTR_ERR(fs_info->fs_root); btrfs_warn(fs_info, "failed to read fs tree: %d", err); + fs_info->fs_root = NULL; goto fail_qgroup; } |