aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ceph/dir.c
diff options
context:
space:
mode:
authorChengguang Xu <cgxu519@gmx.com>2018-07-09 22:17:30 +0800
committerIlya Dryomov <idryomov@gmail.com>2018-08-02 21:26:12 +0200
commit0459871c4995d0bd57d6b1694f0971ec5cabafc1 (patch)
tree23079381371f924e08f306b7a16d46cb72a46e77 /fs/ceph/dir.c
parentceph: return errors from posix_acl_equiv_mode() correctly (diff)
downloadlinux-dev-0459871c4995d0bd57d6b1694f0971ec5cabafc1.tar.xz
linux-dev-0459871c4995d0bd57d6b1694f0971ec5cabafc1.zip
ceph: add d_drop for some error cases in ceph_mknod()
When file num exceeds quota limit or fails from ceph_per_init_acls() should call d_drop to drop dentry from cache as well. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Reviewed-by: "Yan, Zheng" <zyan@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph/dir.c')
-rw-r--r--fs/ceph/dir.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 036ac0f3a393..4b6a49fd2a61 100644
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
@@ -827,12 +827,14 @@ static int ceph_mknod(struct inode *dir, struct dentry *dentry,
if (ceph_snap(dir) != CEPH_NOSNAP)
return -EROFS;
- if (ceph_quota_is_max_files_exceeded(dir))
- return -EDQUOT;
+ if (ceph_quota_is_max_files_exceeded(dir)) {
+ err = -EDQUOT;
+ goto out;
+ }
err = ceph_pre_init_acls(dir, &mode, &acls);
if (err < 0)
- return err;
+ goto out;
dout("mknod in dir %p dentry %p mode 0%ho rdev %d\n",
dir, dentry, mode, rdev);