diff options
| author |   Sage Weil <sage@newdream.net> | 2010-04-01 16:06:19 -0700 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2010-05-17 15:25:18 -0700 |
| commit | a79832f26be370ee26ea81eecdfd42d10e49d66a (patch) | |
| tree | 59d55f3c928558505a420830eddfb01b3186d467 /fs/ceph/file.c | |
| parent | ceph: rewrite msgpool using mempool_t (diff) | |
| download | linux-dev-a79832f26be370ee26ea81eecdfd42d10e49d66a.tar.xz linux-dev-a79832f26be370ee26ea81eecdfd42d10e49d66a.zip | |
ceph: make ceph_msg_new return NULL on failure; clean up, fix callers
Returning ERR_PTR(-ENOMEM) is useless extra work. Return NULL on failure
instead, and fix up the callers (about half of which were wrong anyway).
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph/file.c')
| -rw-r--r-- | fs/ceph/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 834d2b83834a..b0426090e8c3 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -649,8 +649,8 @@ more: do_sync, ci->i_truncate_seq, ci->i_truncate_size, &mtime, false, 2); - if (IS_ERR(req)) - return PTR_ERR(req); + if (!req) + return -ENOMEM; num_pages = calc_pages_for(pos, len); |