diff options
| author |   Sage Weil <sage@inktank.com> | 2013-02-05 13:52:29 -0800 |
|---|---|---|
| committer |   Yan, Zheng <zheng.z.yan@intel.com> | 2014-04-03 10:33:52 +0800 |
| commit | 752c8bdcfe88f27a17c5c9264df928fd145a4b30 (patch) | |
| tree | 755eb2453b772e826113fe30d9184870efb012c0 /fs/ceph/inode.c | |
| parent | ceph: avoid useless ceph_get_dentry_parent_inode() in ceph_rename() (diff) | |
| download | linux-dev-752c8bdcfe88f27a17c5c9264df928fd145a4b30.tar.xz linux-dev-752c8bdcfe88f27a17c5c9264df928fd145a4b30.zip | |
ceph: do not chain inode updates to parent fsync
The fsync(dirfd) only covers namespace operations, not inode updates.
We do not need to cover setattr variants or O_TRUNC.
Reported-by: Al Viro <viro@xeniv.linux.org.uk>
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
Diffstat (limited to 'fs/ceph/inode.c')
| -rw-r--r-- | fs/ceph/inode.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 32d519d8a2e2..8bf2384bd423 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -1627,7 +1627,6 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) { struct inode *inode = dentry->d_inode; struct ceph_inode_info *ci = ceph_inode(inode); - struct inode *parent_inode; const unsigned int ia_valid = attr->ia_valid; struct ceph_mds_request *req; struct ceph_mds_client *mdsc = ceph_sb_to_client(dentry->d_sb)->mdsc; @@ -1819,9 +1818,7 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) req->r_inode_drop = release; req->r_args.setattr.mask = cpu_to_le32(mask); req->r_num_caps = 1; - parent_inode = ceph_get_dentry_parent_inode(dentry); - err = ceph_mdsc_do_request(mdsc, parent_inode, req); - iput(parent_inode); + err = ceph_mdsc_do_request(mdsc, NULL, req); } dout("setattr %p result=%d (%s locally, %d remote)\n", inode, err, ceph_cap_string(dirtied), mask); |