diff options
| author |   Yan, Zheng <zyan@redhat.com> | 2014-09-16 21:46:17 +0800 |
|---|---|---|
| committer |   Ilya Dryomov <idryomov@redhat.com> | 2014-10-14 21:03:38 +0400 |
| commit | 508b32d8661b12da4c9ca41a9b2054e1dc92fa7e (patch) | |
| tree | 81b68ad636814b6ffbc3af1be01276a038b50759 /fs/ceph/ioctl.c | |
| parent | rbd: set the remaining discard properties to enable support (diff) | |
| download | linux-dev-508b32d8661b12da4c9ca41a9b2054e1dc92fa7e.tar.xz linux-dev-508b32d8661b12da4c9ca41a9b2054e1dc92fa7e.zip | |
ceph: request xattrs if xattr_version is zero
Following sequence of events can happen.
- Client releases an inode, queues cap release message.
- A 'lookup' reply brings the same inode back, but the reply
doesn't contain xattrs because MDS didn't receive the cap release
message and thought client already has up-to-data xattrs.
The fix is force sending a getattr request to MDS if xattrs_version
is 0. The getattr mask is set to CEPH_STAT_CAP_XATTR, so MDS knows client
does not have xattr.
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Diffstat (limited to 'fs/ceph/ioctl.c')
| -rw-r--r-- | fs/ceph/ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index a822a6e58290..d7dc812a2249 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c @@ -19,7 +19,7 @@ static long ceph_ioctl_get_layout(struct file *file, void __user *arg) struct ceph_ioctl_layout l; int err; - err = ceph_do_getattr(file_inode(file), CEPH_STAT_CAP_LAYOUT); + err = ceph_do_getattr(file_inode(file), CEPH_STAT_CAP_LAYOUT, false); if (!err) { l.stripe_unit = ceph_file_layout_su(ci->i_layout); l.stripe_count = ceph_file_layout_stripe_count(ci->i_layout); @@ -74,7 +74,7 @@ static long ceph_ioctl_set_layout(struct file *file, void __user *arg) return -EFAULT; /* validate changed params against current layout */ - err = ceph_do_getattr(file_inode(file), CEPH_STAT_CAP_LAYOUT); + err = ceph_do_getattr(file_inode(file), CEPH_STAT_CAP_LAYOUT, false); if (err) return err; |