diff options
| author |   Xiubo Li <xiubli@redhat.com> | 2022-04-11 09:59:09 +0800 |
|---|---|---|
| committer |   Ilya Dryomov <idryomov@gmail.com> | 2022-05-25 20:45:13 +0200 |
| commit | 261998c30004f0e6eeddd24b1eb5e504cfacee18 (patch) | |
| tree | 99d07bc543c264a75f879ce7152db19ab1d59b66 /fs/ceph | |
| parent | ceph: no need to invalidate the fscache twice (diff) | |
| download | linux-dev-261998c30004f0e6eeddd24b1eb5e504cfacee18.tar.xz linux-dev-261998c30004f0e6eeddd24b1eb5e504cfacee18.zip | |
ceph: fix statx AT_STATX_DONT_SYNC vs AT_STATX_FORCE_SYNC check
From the posix and the initial statx supporting commit comments,
the AT_STATX_DONT_SYNC is a lightweight stat and the
AT_STATX_FORCE_SYNC is a heaverweight one. And also checked all
the other current usage about these two flags they are all doing
the same, that is only when the AT_STATX_FORCE_SYNC is not set
and the AT_STATX_DONT_SYNC is set will they skip sync retriving
the attributes from storage.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index e6065483c36b..88d7074d011d 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -2424,7 +2424,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path, return -ESTALE; /* Skip the getattr altogether if we're asked not to sync */ - if (!(flags & AT_STATX_DONT_SYNC)) { + if ((flags & AT_STATX_SYNC_TYPE) != AT_STATX_DONT_SYNC) { err = ceph_do_getattr(inode, statx_to_caps(request_mask, inode->i_mode), flags & AT_STATX_FORCE_SYNC); |