diff options
| author |   Al Viro <viro@zeniv.linux.org.uk> | 2021-03-05 15:02:34 -0500 |
|---|---|---|
| committer |   Steve French <stfrench@microsoft.com> | 2021-04-25 16:28:23 -0500 |
| commit | 8d7672235533dbeab4a5373b49f1b4273cdc2c6a (patch) | |
| tree | e86654fbc3d834f515bcc97d77f36ae7ba5649d4 /fs/cifs/cifs_dfs_ref.c | |
| parent | SMB3: update structures for new compression protocol definitions (diff) | |
| download | linux-dev-8d7672235533dbeab4a5373b49f1b4273cdc2c6a.tar.xz linux-dev-8d7672235533dbeab4a5373b49f1b4273cdc2c6a.zip | |
cifs: don't cargo-cult strndup()
strndup(s, strlen(s)) is a highly unidiomatic way to spell strdup(s);
it's *NOT* safer in any way, since strlen() is just as sensitive to
NUL-termination as strdup() is.
strndup() is for situations when you need a copy of a known-sized
substring, not a magic security juju to drive the bad spirits away.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/cifs_dfs_ref.c')
| -rw-r--r-- | fs/cifs/cifs_dfs_ref.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c index 6b1ce4efb591..ecee2864972d 100644 --- a/fs/cifs/cifs_dfs_ref.c +++ b/fs/cifs/cifs_dfs_ref.c @@ -270,7 +270,7 @@ static struct vfsmount *cifs_dfs_do_mount(struct dentry *mntpt, char *mountdata; char *devname; - devname = kstrndup(fullpath, strlen(fullpath), GFP_KERNEL); + devname = kstrdup(fullpath, GFP_KERNEL); if (!devname) return ERR_PTR(-ENOMEM); |