diff options
| author |   Ronnie Sahlberg <lsahlber@redhat.com> | 2022-02-12 08:16:20 +1000 |
|---|---|---|
| committer |   Steve French <stfrench@microsoft.com> | 2022-02-13 14:56:46 -0600 |
| commit | 26d3dadebbcbddfaf1d9caad42527a28a0ed28d8 (patch) | |
| tree | 1fe0b5c4a70abbc036b86c6331b56bbd91342509 /fs/cifs/cifsacl.c | |
| parent | cifs: fix set of group SID via NTSD xattrs (diff) | |
| download | linux-dev-26d3dadebbcbddfaf1d9caad42527a28a0ed28d8.tar.xz linux-dev-26d3dadebbcbddfaf1d9caad42527a28a0ed28d8.zip | |
cifs: do not use uninitialized data in the owner/group sid
When idsfromsid is used we create a special SID for owner/group.
This structure must be initialized or else the first 5 bytes
of the Authority field of the SID will contain uninitialized data
and thus not be a valid SID.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/cifsacl.c')
| -rw-r--r-- | fs/cifs/cifsacl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c index ee3aab3dd4ac..5df21d63dd04 100644 --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -1297,7 +1297,7 @@ static int build_sec_desc(struct cifs_ntsd *pntsd, struct cifs_ntsd *pnntsd, if (uid_valid(uid)) { /* chown */ uid_t id; - nowner_sid_ptr = kmalloc(sizeof(struct cifs_sid), + nowner_sid_ptr = kzalloc(sizeof(struct cifs_sid), GFP_KERNEL); if (!nowner_sid_ptr) { rc = -ENOMEM; @@ -1326,7 +1326,7 @@ static int build_sec_desc(struct cifs_ntsd *pntsd, struct cifs_ntsd *pnntsd, } if (gid_valid(gid)) { /* chgrp */ gid_t id; - ngroup_sid_ptr = kmalloc(sizeof(struct cifs_sid), + ngroup_sid_ptr = kzalloc(sizeof(struct cifs_sid), GFP_KERNEL); if (!ngroup_sid_ptr) { rc = -ENOMEM; |