diff options
| author |   Steve French <smfrench@gmail.com> | 2014-02-07 20:45:12 -0600 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2014-02-07 20:47:00 -0600 |
| commit | 4a5c80d7b5615be8098f9d5da97d166afc318abc (patch) | |
| tree | ff3e40a816442722056805cc0cc1844051a30988 /fs/cifs/cifsproto.h | |
| parent | cifs: use a flexarray in cifs_writedata (diff) | |
| download | linux-dev-4a5c80d7b5615be8098f9d5da97d166afc318abc.tar.xz linux-dev-4a5c80d7b5615be8098f9d5da97d166afc318abc.zip | |
[CIFS] clean up page array when uncached write send fails
In the event that a send fails in an uncached write, or we end up
needing to reissue it (-EAGAIN case), we'll kfree the wdata but
the pages currently leak.
Fix this by adding a new kref release routine for uncached writedata
that releases the pages, and have the uncached codepaths use that.
[original patch by Jeff modified to fix minor formatting problems]
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs/cifsproto.h')
| -rw-r--r-- | fs/cifs/cifsproto.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index 79e6e9a93a8c..d00e09dfc452 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h @@ -488,7 +488,8 @@ void cifs_readdata_release(struct kref *refcount); int cifs_async_readv(struct cifs_readdata *rdata); int cifs_readv_receive(struct TCP_Server_Info *server, struct mid_q_entry *mid); -int cifs_async_writev(struct cifs_writedata *wdata); +int cifs_async_writev(struct cifs_writedata *wdata, + void (*release)(struct kref *kref)); void cifs_writev_complete(struct work_struct *work); struct cifs_writedata *cifs_writedata_alloc(unsigned int nr_pages, work_func_t complete); |