aboutsummaryrefslogtreecommitdiffstats
path: root/fs/cifs/smb2pdu.c
diff options
context:
space:
mode:
authorSteve French <stfrench@microsoft.com>2019-09-22 00:55:46 -0500
committerSteve French <stfrench@microsoft.com>2019-09-23 22:48:36 -0500
commitd2f15428d6a0ebfc0edc364094d7c4a2de7037ed (patch)
treee89cc8393e3d27448b96e74643263c41ac529ec3 /fs/cifs/smb2pdu.c
parentsmb3: allow decryption keys to be dumped by admin for debugging (diff)
downloadlinux-dev-d2f15428d6a0ebfc0edc364094d7c4a2de7037ed.tar.xz
linux-dev-d2f15428d6a0ebfc0edc364094d7c4a2de7037ed.zip
smb3: fix leak in "open on server" perf counter
We were not bumping up the "open on server" (num_remote_opens) counter (in some cases) on opens of the share root so could end up showing as a negative value. CC: Stable <stable@vger.kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
-rw-r--r--fs/cifs/smb2pdu.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 87066f1af12c..5f2491efd950 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -2352,6 +2352,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
rqst.rq_iov = iov;
rqst.rq_nvec = n_iov;
+ /* no need to inc num_remote_opens because we close it just below */
trace_smb3_posix_mkdir_enter(xid, tcon->tid, ses->Suid, CREATE_NOT_FILE,
FILE_WRITE_ATTRIBUTES);
/* resource #4: response buffer */