diff options
| author |   Steve French <stfrench@microsoft.com> | 2021-09-23 19:18:37 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-09-23 21:12:53 -0500 |
| commit | 9ed38fd4a15417cac83967360cf20b853bfab9b6 (patch) | |
| tree | 4de3dbe567271625429f6ad2702217cbab05dcbd /fs/cifs | |
| parent | smb3: correct server pointer dereferencing check to be more consistent (diff) | |
| download | linux-dev-9ed38fd4a15417cac83967360cf20b853bfab9b6.tar.xz linux-dev-9ed38fd4a15417cac83967360cf20b853bfab9b6.zip | |
cifs: fix incorrect check for null pointer in header_assemble
Although very unlikely that the tlink pointer would be null in this case,
get_next_mid function can in theory return null (but not an error)
so need to check for null (not for IS_ERR, which can not be returned
here).
Address warning:
fs/smbfs_client/connect.c:2392 cifs_match_super()
warn: 'tlink' isn't an ERR_PTR
Pointed out by Dan Carpenter via smatch code analysis tool
CC: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/connect.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 7881115cfbee..c3b94c1e4591 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -2389,9 +2389,10 @@ cifs_match_super(struct super_block *sb, void *data) spin_lock(&cifs_tcp_ses_lock); cifs_sb = CIFS_SB(sb); tlink = cifs_get_tlink(cifs_sb_master_tlink(cifs_sb)); - if (IS_ERR(tlink)) { + if (tlink == NULL) { + /* can not match superblock if tlink were ever null */ spin_unlock(&cifs_tcp_ses_lock); - return rc; + return 0; } tcon = tlink_tcon(tlink); ses = tcon->ses; |