diff options
| author |   Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-03 21:17:27 +0800 |
|---|---|---|
| committer |   Jan Kara <jack@suse.cz> | 2019-07-03 16:24:25 +0200 |
| commit | 90f15ac9fa7e7ff66e0980309d8184bff0611624 (patch) | |
| tree | 7a486f87d06779c52b6ebb2ea95383d84fbcda68 /fs/ext2/xattr.c | |
| parent | quota: honor quota type in Q_XGETQSTAT[V] calls (diff) | |
| download | linux-dev-90f15ac9fa7e7ff66e0980309d8184bff0611624.tar.xz linux-dev-90f15ac9fa7e7ff66e0980309d8184bff0611624.zip | |
ext2: Use kmemdup rather than duplicating its implementation
kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memset, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190703131727.25735-1-huangfq.daxian@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2/xattr.c')
| -rw-r--r-- | fs/ext2/xattr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 839e71e78673..79369c13cc55 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -532,11 +532,10 @@ bad_block: unlock_buffer(bh); ea_bdebug(bh, "cloning"); - header = kmalloc(bh->b_size, GFP_KERNEL); + header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL); error = -ENOMEM; if (header == NULL) goto cleanup; - memcpy(header, HDR(bh), bh->b_size); header->h_refcount = cpu_to_le32(1); offset = (char *)here - bh->b_data; |