diff options
| author |   Jan Kara <jack@suse.cz> | 2021-02-04 18:05:42 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2021-07-13 14:29:00 +0200 |
| commit | d4f5258eae7b38c2a28d0a7b28a6d0a8c1f9fe8e (patch) | |
| tree | 9878725ed6feb4691c42d900917fe89775ee8439 /fs/ext4/ioctl.c | |
| parent | mm: Add functions to lock invalidate_lock for two mappings (diff) | |
| download | linux-dev-d4f5258eae7b38c2a28d0a7b28a6d0a8c1f9fe8e.tar.xz linux-dev-d4f5258eae7b38c2a28d0a7b28a6d0a8c1f9fe8e.zip | |
ext4: Convert to use mapping->invalidate_lock
Convert ext4 to use mapping->invalidate_lock instead of its private
EXT4_I(inode)->i_mmap_sem. This is mostly search-and-replace. By this
conversion we fix a long standing race between hole punching and read(2)
/ readahead(2) paths that can lead to stale page cache contents.
CC: <linux-ext4@vger.kernel.org>
CC: Ted Tso <tytso@mit.edu>
Acked-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext4/ioctl.c')
| -rw-r--r-- | fs/ext4/ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 6eed6170aded..4fb5fe083c2b 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -148,7 +148,7 @@ static long swap_inode_boot_loader(struct super_block *sb, goto journal_err_out; } - down_write(&EXT4_I(inode)->i_mmap_sem); + filemap_invalidate_lock(inode->i_mapping); err = filemap_write_and_wait(inode->i_mapping); if (err) goto err_out; @@ -256,7 +256,7 @@ err_out1: ext4_double_up_write_data_sem(inode, inode_bl); err_out: - up_write(&EXT4_I(inode)->i_mmap_sem); + filemap_invalidate_unlock(inode->i_mapping); journal_err_out: unlock_two_nondirectories(inode, inode_bl); iput(inode_bl); |