diff options
| author |   Joseph Qi <joseph.qi@linux.alibaba.com> | 2021-04-26 14:29:47 +0800 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2021-06-17 10:53:19 -0400 |
| commit | 5c680150d7f43484fde6b87271229f2206bfff7c (patch) | |
| tree | d8cb488d431721ee13ce02dbbf55761a83293f56 /fs/ext4 | |
| parent | ext4: fix overflow in ext4_iomap_alloc() (diff) | |
| download | linux-dev-5c680150d7f43484fde6b87271229f2206bfff7c.tar.xz linux-dev-5c680150d7f43484fde6b87271229f2206bfff7c.zip | |
ext4: remove redundant check buffer_uptodate()
Now set_buffer_uptodate() will test first and then set, so we don't have
to check buffer_uptodate() first, remove it to simplify code.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Link: https://lore.kernel.org/r/1619418587-5580-1-git-send-email-joseph.qi@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/ext4.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 37002663d521..639ab5405d6a 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -3784,7 +3784,7 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh) * have to read the block because we may read the old data * successfully. */ - if (!buffer_uptodate(bh) && buffer_write_io_error(bh)) + if (buffer_write_io_error(bh)) set_buffer_uptodate(bh); return buffer_uptodate(bh); } |