diff options
| author |   Theodore Ts'o <tytso@mit.edu> | 2020-11-19 15:36:25 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-11-19 15:41:57 -0500 |
| commit | 704c2317cab5571da0e5763cd47ad07f8900aa76 (patch) | |
| tree | 6f55a40282fe6423242215140fb2ea0209aae166 /fs/ext4 | |
| parent | Linux 5.10-rc4 (diff) | |
| download | linux-dev-704c2317cab5571da0e5763cd47ad07f8900aa76.tar.xz linux-dev-704c2317cab5571da0e5763cd47ad07f8900aa76.zip | |
ext4: drop fast_commit from /proc/mounts
The options in /proc/mounts must be valid mount options --- and
fast_commit is not a mount option. Otherwise, command sequences like
this will fail:
# mount /dev/vdc /vdc
# mkdir -p /vdc/phoronix_test_suite /pts
# mount --bind /vdc/phoronix_test_suite /pts
# mount -o remount,nodioread_nolock /pts
mount: /pts: mount point not mounted or bad option.
And in the system logs, you'll find:
EXT4-fs (vdc): Unrecognized mount option "fast_commit" or missing value
Fixes: 995a3ed67fc8 ("ext4: add fast_commit feature and handling for extended mount options")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/super.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 6633b20224d5..94472044f4c1 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2638,10 +2638,6 @@ static int _ext4_show_options(struct seq_file *seq, struct super_block *sb, } else if (test_opt2(sb, DAX_INODE)) { SEQ_OPTS_PUTS("dax=inode"); } - - if (test_opt2(sb, JOURNAL_FAST_COMMIT)) - SEQ_OPTS_PUTS("fast_commit"); - ext4_show_quota_options(seq, sb); return 0; } |