diff options
| author |   Harshad Shirwadkar <harshadshirwadkar@gmail.com> | 2021-12-23 12:21:40 -0800 |
|---|---|---|
| committer |   Theodore Ts'o <tytso@mit.edu> | 2021-12-23 18:13:25 -0500 |
| commit | d1199b94474ac4513b8491a4b751a8a466e1886b (patch) | |
| tree | 71c592248214dc114bbc79dedefbb9c117caf59b /fs/ext4 | |
| parent | ext4: simplify updating of fast commit stats (diff) | |
| download | linux-dev-d1199b94474ac4513b8491a4b751a8a466e1886b.tar.xz linux-dev-d1199b94474ac4513b8491a4b751a8a466e1886b.zip | |
ext4: update fast commit TODOs
This series takes care of a couple of TODOs and adds new ones. Update
the TODOs section to reflect current state and future work that needs
to happen.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20211223202140.2061101-5-harshads@google.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/fast_commit.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index a37384054c9e..dd002facf6c9 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -156,15 +156,13 @@ * fast commit recovery even if that area is invalidated by later full * commits. * - * 1) Make fast commit atomic updates more fine grained. Today, a fast commit - * eligible update must be protected within ext4_fc_start_update() and - * ext4_fc_stop_update(). These routines are called at much higher - * routines. This can be made more fine grained by combining with - * ext4_journal_start(). + * 1) Fast commit's commit path locks the entire file system during fast + * commit. This has significant performance penalty. Instead of that, we + * should use ext4_fc_start/stop_update functions to start inode level + * updates from ext4_journal_start/stop. Once we do that we can drop file + * system locking during commit path. * - * 2) Same above for ext4_fc_start_ineligible() and ext4_fc_stop_ineligible() - * - * 3) Handle more ineligible cases. + * 2) Handle more ineligible cases. */ #include <trace/events/ext4.h> |