aboutsummaryrefslogtreecommitdiffstats
path: root/fs/f2fs/acl.c
diff options
context:
space:
mode:
authorChengguang Xu <cgxu519@gmx.com>2018-08-30 21:33:31 +0800
committerJaegeuk Kim <jaegeuk@kernel.org>2018-09-05 13:40:31 -0700
commit1618e6e297082def6350887e1c6c606749716fac (patch)
tree7e533c0fffd3b552aadae0cf02cbc7385a1cb503 /fs/f2fs/acl.c
parentMerge tag 'gpio-v4.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio (diff)
downloadlinux-dev-1618e6e297082def6350887e1c6c606749716fac.tar.xz
linux-dev-1618e6e297082def6350887e1c6c606749716fac.zip
f2fs: add additional sanity check in f2fs_acl_from_disk()
Add additinal sanity check for irregular case(e.g. corruption). If size of extended attribution is smaller than size of acl header, then return -EINVAL. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/acl.c')
-rw-r--r--fs/f2fs/acl.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 111824199a88..20caf341701d 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -53,6 +53,9 @@ static struct posix_acl *f2fs_acl_from_disk(const char *value, size_t size)
struct f2fs_acl_entry *entry = (struct f2fs_acl_entry *)(hdr + 1);
const char *end = value + size;
+ if (size < sizeof(struct f2fs_acl_header))
+ return ERR_PTR(-EINVAL);
+
if (hdr->a_version != cpu_to_le32(F2FS_ACL_VERSION))
return ERR_PTR(-EINVAL);