aboutsummaryrefslogtreecommitdiffstats
path: root/fs/f2fs/debug.c
diff options
context:
space:
mode:
authorChao Yu <chao2.yu@samsung.com>2015-08-19 19:11:19 +0800
committerJaegeuk Kim <jaegeuk@kernel.org>2015-08-21 22:45:14 -0700
commite2b4e2bc8865e03eecd49caa9713a2402a96bba9 (patch)
treea1c1c7e2effcb9816fa7151ebe4d1cc1533616d5 /fs/f2fs/debug.c
parentf2fs: add annotation for space utilization of regular/inline dentry (diff)
downloadlinux-dev-e2b4e2bc8865e03eecd49caa9713a2402a96bba9.tar.xz
linux-dev-e2b4e2bc8865e03eecd49caa9713a2402a96bba9.zip
f2fs: fix incorrect mapping for bmap
The test step is like below: 1. touch file 2. truncate -s $((1024*1024)) file 3. fallocate -o 0 -l $((1024*1024)) file 4. fibmap.f2fs file Our result of fibmap.f2fs showed below is not correct: file_pos start_blk end_blk blks 0 -937166132 -937166132 1 4096 -937166132 -937166132 1 8192 -937166132 -937166132 1 12288 -937166132 -937166132 1 16384 -937166132 -937166132 1 20480 -937166132 -937166132 1 ... 1040384 -937166132 -937166132 1 1044480 -937166132 -937166132 1 This is because f2fs_map_blocks will return with no error when meeting a hole or preallocated block, the caller __get_data_block will map the uninitialized variable value to bh->b_blocknr. Unfortunately generic_block_bmap will neither check the return value of get_data() nor check mapping info of buffer_head, result in returning the random block address. After fixing the issue, our result shows correctly: file_pos start_blk end_blk blks 0 0 0 256 Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/debug.c')
0 files changed, 0 insertions, 0 deletions