diff options
author | Vyacheslav Dubeyko <slava@dubeyko.com> | 2013-08-22 16:35:45 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-08-23 09:51:22 -0700 |
commit | 4bf93b50fd04118ac7f33a3c2b8a0a1f9fa80bc9 (patch) | |
tree | 46da4b4982c9b6cca343b25c3869bf93a23cbed7 /fs/file_table.c | |
parent | nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error (diff) | |
download | linux-dev-4bf93b50fd04118ac7f33a3c2b8a0a1f9fa80bc9.tar.xz linux-dev-4bf93b50fd04118ac7f33a3c2b8a0a1f9fa80bc9.zip |
nilfs2: fix issue with counting number of bio requests for BIO_EOPNOTSUPP error detection
Fix the issue with improper counting number of flying bio requests for
BIO_EOPNOTSUPP error detection case.
The sb_nbio must be incremented exactly the same number of times as
complete() function was called (or will be called) because
nilfs_segbuf_wait() will call wail_for_completion() for the number of
times set to sb_nbio:
do {
wait_for_completion(&segbuf->sb_bio_event);
} while (--segbuf->sb_nbio > 0);
Two functions complete() and wait_for_completion() must be called the
same number of times for the same sb_bio_event. Otherwise,
wait_for_completion() will hang or leak.
Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/file_table.c')
0 files changed, 0 insertions, 0 deletions