diff options
| author |   Andreas Gruenbacher <agruenba@redhat.com> | 2021-07-28 07:47:34 -0500 |
|---|---|---|
| committer |   Al Viro <viro@zeniv.linux.org.uk> | 2021-08-13 00:41:05 -0400 |
| commit | d75b9fa053e4cd278281386d860c26fdbfbe9d03 (patch) | |
| tree | befab30b224cb9b08204d883bd21469869ac76d2 /fs/gfs2/inode.c | |
| parent | fs: Move notify_change permission checks into may_setattr (diff) | |
| download | linux-dev-d75b9fa053e4cd278281386d860c26fdbfbe9d03.tar.xz linux-dev-d75b9fa053e4cd278281386d860c26fdbfbe9d03.zip | |
gfs2: Switch to may_setattr in gfs2_setattr
The permission check in gfs2_setattr is an old and outdated version of
may_setattr(). Switch to the updated version.
Fixes fstest generic/079.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/gfs2/inode.c')
| -rw-r--r-- | fs/gfs2/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 6e15434b23ac..3130f85d2b3f 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1985,8 +1985,8 @@ static int gfs2_setattr(struct user_namespace *mnt_userns, if (error) goto out; - error = -EPERM; - if (IS_IMMUTABLE(inode) || IS_APPEND(inode)) + error = may_setattr(&init_user_ns, inode, attr->ia_valid); + if (error) goto error; error = setattr_prepare(&init_user_ns, dentry, attr); |