diff options
| author |   Bob Peterson <rpeterso@redhat.com> | 2019-04-10 11:46:35 -0600 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2020-02-10 07:39:49 -0600 |
| commit | 036330c914365f449ead353ef152fb29411cd4cb (patch) | |
| tree | 27a4710422dd28daf10615d86b4df8bb63b6bced /fs/gfs2/quota.c | |
| parent | gfs2: Rework how rgrp buffer_heads are managed (diff) | |
| download | linux-dev-036330c914365f449ead353ef152fb29411cd4cb.tar.xz linux-dev-036330c914365f449ead353ef152fb29411cd4cb.zip | |
gfs2: log error reform
Before this patch, gfs2 kept track of journal io errors in two
places sd_log_error and the SDF_AIL1_IO_ERROR flag in sd_flags.
This patch consolidates the two into sd_log_error so that it
reflects the first error encountered writing to the journal.
In future patches, we will take advantage of this by checking
this value rather than having to check both when reacting to
io errors.
In addition, this fixes a tight loop in unmount: If buffers
get on the ail1 list and an io error occurs elsewhere, the
ail1 list would never be cleared because they were always busy.
So unmount would hang, waiting for the ail1 list to empty.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2/quota.c')
| -rw-r--r-- | fs/gfs2/quota.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index e9f93045eb01..ca2194cfa38e 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1477,7 +1477,7 @@ static void quotad_error(struct gfs2_sbd *sdp, const char *msg, int error) return; if (!gfs2_withdrawn(sdp)) { fs_err(sdp, "gfs2_quotad: %s error %d\n", msg, error); - sdp->sd_log_error = error; + cmpxchg(&sdp->sd_log_error, 0, error); wake_up(&sdp->sd_logd_waitq); } } |