diff options
| author |   Bob Peterson <rpeterso@redhat.com> | 2020-05-04 10:18:43 -0500 |
|---|---|---|
| committer |   Andreas Gruenbacher <agruenba@redhat.com> | 2020-05-08 18:45:11 +0200 |
| commit | 2297ab6144c2e85c418d0fd47b2f24e294b55dca (patch) | |
| tree | 551bfdeaee8b976bb2398cab1b8de18dbf422beb /fs/gfs2/super.c | |
| parent | gfs2: More gfs2_find_jhead fixes (diff) | |
| download | linux-dev-2297ab6144c2e85c418d0fd47b2f24e294b55dca.tar.xz linux-dev-2297ab6144c2e85c418d0fd47b2f24e294b55dca.zip | |
gfs2: Fix problems regarding gfs2_qa_get and _put
This patch fixes a couple of places in which gfs2_qa_get and gfs2_qa_put are
not balanced: we now keep references around whenever a file is open for writing
(see gfs2_open_common and gfs2_release), so we need to put all references we
grab in function gfs2_create_inode. This was broken in the successful case and
on one error path.
This also means that we don't have a reference to put in gfs2_evict_inode.
In addition, gfs2_qa_put was called for the wrong inode in gfs2_link.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2/super.c')
| -rw-r--r-- | fs/gfs2/super.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 37fc41632aa2..956fced0a8ec 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -1404,7 +1404,6 @@ out: if (ip->i_qadata) gfs2_assert_warn(sdp, ip->i_qadata->qa_ref == 0); gfs2_rs_delete(ip, NULL); - gfs2_qa_put(ip); gfs2_ordered_del_inode(ip); clear_inode(inode); gfs2_dir_hash_inval(ip); |