diff options
| author |   Andrew Price <anprice@redhat.com> | 2018-10-08 07:52:43 -0500 |
|---|---|---|
| committer |   Bob Peterson <rpeterso@redhat.com> | 2018-10-08 07:52:43 -0500 |
| commit | 4c62bd9cea7bcf10292f7e4c57a2bca332942697 (patch) | |
| tree | 4f25341b2191bf08d1d0182e75cbdc50732fb0c7 /fs/gfs2 | |
| parent | gfs2: Use fs_* functions instead of pr_* function where we can (diff) | |
| download | linux-dev-4c62bd9cea7bcf10292f7e4c57a2bca332942697.tar.xz linux-dev-4c62bd9cea7bcf10292f7e4c57a2bca332942697.zip | |
gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd
When alloc_percpu() fails, sdp gets freed but sb->s_fs_info still points
to the same address. Move the assignment after that error check so that
s_fs_info can only point to a valid sdp or NULL, which is checked for
later in the error path, in gfs2_kill_super().
Reported-by: syzbot+dcb8b3587445007f5808@syzkaller.appspotmail.com
Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/ops_fstype.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index c2469833b4fb..4ec69d9783a8 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -72,13 +72,13 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) if (!sdp) return NULL; - sb->s_fs_info = sdp; sdp->sd_vfs = sb; sdp->sd_lkstats = alloc_percpu(struct gfs2_pcpu_lkstats); if (!sdp->sd_lkstats) { kfree(sdp); return NULL; } + sb->s_fs_info = sdp; set_bit(SDF_NOJOURNALID, &sdp->sd_flags); gfs2_tune_init(&sdp->sd_tune); |