diff options
| author |   Andreas Gruenbacher <agruenba@redhat.com> | 2021-04-02 19:51:24 +0200 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2021-04-03 21:38:12 +0200 |
| commit | bea906ee1624aeb34ea2c5acca84728de4185726 (patch) | |
| tree | 2e47f1b828f3f14b6a3eab4892ff0bcc9beebc75 /fs/gfs2 | |
| parent | gfs2: Turn gfs2_meta_indirect_buffer into gfs2_meta_buffer (diff) | |
| download | linux-dev-bea906ee1624aeb34ea2c5acca84728de4185726.tar.xz linux-dev-bea906ee1624aeb34ea2c5acca84728de4185726.zip | |
gfs2: Silence possible null pointer dereference warning
In gfs2_rbm_find, rs is always NULL when minext is NULL, so
gfs2_reservation_check_and_update will never be called on a NULL minext.
This isn't innediately obvious though, so also check for a NULL minext
for better code readability.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/rgrp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 89c37a845e64..2dab313442a7 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1783,7 +1783,7 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext, goto next_bitmap; } rbm->offset = offset; - if (!rs) + if (!rs || !minext) return 0; ret = gfs2_reservation_check_and_update(rbm, rs, *minext, |