diff options
| author |   Christoph Hellwig <hch@lst.de> | 2009-05-11 23:35:03 +0200 |
|---|---|---|
| committer |   Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:09 -0400 |
| commit | ebc1ac164560a241d9bf1b7519062910c3f90a01 (patch) | |
| tree | db17fd3043b15f8269cce2c2d00213814022fc30 /fs/hfs | |
| parent | jffs2: move jffs2_write_super to super.c (diff) | |
| download | linux-dev-ebc1ac164560a241d9bf1b7519062910c3f90a01.tar.xz linux-dev-ebc1ac164560a241d9bf1b7519062910c3f90a01.zip | |
->write_super lock_super pushdown
Push down lock_super into ->write_super instances and remove it from the
caller.
Following filesystem don't need ->s_lock in ->write_super and are skipped:
* bfs, nilfs2 - no other uses of s_lock and have internal locks in
->write_super
* ext2 - uses BKL in ext2_write_super and has internal calls without s_lock
* reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in
->write_super
* xfs - no other uses of s_lock and uses internal lock (buffer lock on
superblock buffer) to serialize ->write_super. Also xfs_fs_write_super
is superflous and will go away in the next merge window
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hfs')
| -rw-r--r-- | fs/hfs/super.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/hfs/super.c b/fs/hfs/super.c index 9f5eaa01cc77..3aac41751030 100644 --- a/fs/hfs/super.c +++ b/fs/hfs/super.c @@ -49,11 +49,13 @@ MODULE_LICENSE("GPL"); */ static void hfs_write_super(struct super_block *sb) { + lock_super(sb); sb->s_dirt = 0; - if (sb->s_flags & MS_RDONLY) - return; + /* sync everything to the buffers */ - hfs_mdb_commit(sb); + if (!(sb->s_flags & MS_RDONLY)) + hfs_mdb_commit(sb); + unlock_super(sb); } /* |