diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-05-05 23:01:22 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2019-05-06 10:21:34 -0600 |
| commit | efeb862bd5bc001636e690debf6f9fbba98e5bfd (patch) | |
| tree | bbbf2474fb20d22f05fc8b8899ac189dae81e189 /fs/io_uring.c | |
| parent | req->error only used for iopoll (diff) | |
| download | linux-dev-efeb862bd5bc001636e690debf6f9fbba98e5bfd.tar.xz linux-dev-efeb862bd5bc001636e690debf6f9fbba98e5bfd.zip | |
io_uring: fix shadowed variable ret return code being not checked
Currently variable ret is declared in a while-loop code block that
shadows another variable ret. When an error occurs in the while-loop
the error return in ret is not being set in the outer code block and
so the error check on ret is always going to be checking on the wrong
ret variable resulting in check that is always going to be true and
a premature return occurs.
Fix this by removing the declaration of the inner while-loop variable
ret so that shadowing does not occur.
Addresses-Coverity: ("'Constant' variable guards dead code")
Fixes: 6b06314c47e1 ("io_uring: add file set registration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index d91cbd53d3ca..1157a068c253 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2363,7 +2363,6 @@ static int io_sqe_files_scm(struct io_ring_ctx *ctx) left = ctx->nr_user_files; while (left) { unsigned this_files = min_t(unsigned, left, SCM_MAX_FD); - int ret; ret = __io_sqe_files_scm(ctx, this_files, total); if (ret) |