diff options
| author |   Alexey Dobriyan <adobriyan@sw.ru> | 2007-05-08 00:25:49 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-08 11:15:02 -0700 |
| commit | 578c8183c116e623d53b05d4c79762d053c7090f (patch) | |
| tree | 783cb8471e5efdb486fc7dd4f5de53038a96f8a7 /fs/ioctl.c | |
| parent | Fix race between proc_readdir and remove_proc_entry (diff) | |
| download | linux-dev-578c8183c116e623d53b05d4c79762d053c7090f.tar.xz linux-dev-578c8183c116e623d53b05d4c79762d053c7090f.zip | |
proc: remove pathetic ->deleted WARN_ON
WARN_ON(de && de->deleted); is sooo unreliable. Why?
proc_lookup remove_proc_entry
=========== =================
lock_kernel();
spin_lock(&proc_subdir_lock);
[find proc entry]
spin_unlock(&proc_subdir_lock);
spin_lock(&proc_subdir_lock);
[find proc entry]
proc_get_inode
==============
WARN_ON(de && de->deleted); ...
if (!atomic_read(&de->count))
free_proc_entry(de);
else
de->deleted = 1;
So, if you have some strange oops [1], and doesn't see this WARN_ON it means
nothing.
[1] try_module_get() of module which doesn't exist, two lines below
should suffice, or not?
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ioctl.c')
0 files changed, 0 insertions, 0 deletions