diff options
| author |   Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2008-05-21 10:45:16 -0500 |
|---|---|---|
| committer | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2008-05-21 10:45:16 -0500 |
| commit | 6536d2891ba2c4e837ba8478dc13bb173ed24a23 (patch) | |
| tree | 22faac43152fb205f925bcec9c1c003573147a01 /fs/jfs | |
| parent | JFS: switch to seq_files (diff) | |
| download | linux-dev-6536d2891ba2c4e837ba8478dc13bb173ed24a23.tar.xz linux-dev-6536d2891ba2c4e837ba8478dc13bb173ed24a23.zip | |
JFS: skip bad iput() call in error path
If jfs_iget() fails, we can't call iput() on the returned error.
Thanks to Eric Sesterhenn's fuzzer testing for reporting the problem.
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Diffstat (limited to 'fs/jfs')
| -rw-r--r-- | fs/jfs/super.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/jfs/super.c b/fs/jfs/super.c index 50ea65451732..0288e6d7936a 100644 --- a/fs/jfs/super.c +++ b/fs/jfs/super.c @@ -499,7 +499,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) inode = jfs_iget(sb, ROOT_I); if (IS_ERR(inode)) { ret = PTR_ERR(inode); - goto out_no_root; + goto out_no_rw; } sb->s_root = d_alloc_root(inode); if (!sb->s_root) @@ -521,9 +521,8 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent) return 0; out_no_root: - jfs_err("jfs_read_super: get root inode failed"); - if (inode) - iput(inode); + jfs_err("jfs_read_super: get root dentry failed"); + iput(inode); out_no_rw: rc = jfs_umount(sb); |