diff options
| author |   Scott Mayhew <smayhew@redhat.com> | 2020-08-01 07:10:38 -0400 |
|---|---|---|
| committer |   Trond Myklebust <trond.myklebust@hammerspace.com> | 2020-08-01 15:37:48 -0400 |
| commit | 67dd23f9e6fbaf163431912ef5599c5e0693476c (patch) | |
| tree | 38c5b336d3c1ccddc3348a030423ab243d580501 /fs/nfs/file.c | |
| parent | NFSv4.2: xattr cache: get rid of cache discard work queue (diff) | |
| download | linux-dev-67dd23f9e6fbaf163431912ef5599c5e0693476c.tar.xz linux-dev-67dd23f9e6fbaf163431912ef5599c5e0693476c.zip | |
nfs: ensure correct writeback errors are returned on close()
nfs_wb_all() calls filemap_write_and_wait(), which uses
filemap_check_errors() to determine the error to return.
filemap_check_errors() only looks at the mapping->flags and will
therefore only return either -ENOSPC or -EIO. To ensure that the
correct error is returned on close(), nfs{,4}_file_flush() should call
filemap_check_wb_err() which looks at the errseq value in
mapping->wb_err without consuming it.
Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with
generic one")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs/file.c')
| -rw-r--r-- | fs/nfs/file.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index ccd6c1637b27..bb244fc39d4b 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c @@ -141,6 +141,7 @@ static int nfs_file_flush(struct file *file, fl_owner_t id) { struct inode *inode = file_inode(file); + errseq_t since; dprintk("NFS: flush(%pD2)\n", file); @@ -149,7 +150,9 @@ nfs_file_flush(struct file *file, fl_owner_t id) return 0; /* Flush writes to the server and return any errors */ - return nfs_wb_all(inode); + since = filemap_sample_wb_err(file->f_mapping); + nfs_wb_all(inode); + return filemap_check_wb_err(file->f_mapping, since); } ssize_t |