diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2017-05-20 00:31:12 +0300 |
|---|---|---|
| committer |   Trond Myklebust <trond.myklebust@primarydata.com> | 2017-05-24 07:52:54 -0400 |
| commit | 662f9a105b4322b8559d448f86110e6ec24b8738 (patch) | |
| tree | 2358ff5c962e91ec5c1d4bcf55e6b4d172351987 /fs/nfs/flexfilelayout | |
| parent | NFS fix COMMIT after COPY (diff) | |
| download | linux-dev-662f9a105b4322b8559d448f86110e6ec24b8738.tar.xz linux-dev-662f9a105b4322b8559d448f86110e6ec24b8738.zip | |
pNFS/flexfiles: missing error code in ff_layout_alloc_lseg()
If xdr_inline_decode() fails then we end up returning ERR_PTR(0). The
caller treats NULL returns as -ENOMEM so it doesn't really hurt runtime,
but obviously we intended to set an error code here.
Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/flexfilelayout')
| -rw-r--r-- | fs/nfs/flexfilelayout/flexfilelayout.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout/flexfilelayout.c index f5714ee01000..23542dc44a25 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -454,6 +454,7 @@ ff_layout_alloc_lseg(struct pnfs_layout_hdr *lh, goto out_err_free; /* fh */ + rc = -EIO; p = xdr_inline_decode(&stream, 4); if (!p) goto out_err_free; |