diff options
| author |   Chengguang Xu <cgxu519@gmx.com> | 2018-06-22 09:49:36 +0800 |
|---|---|---|
| committer |   Miklos Szeredi <mszeredi@redhat.com> | 2018-10-26 23:34:40 +0200 |
| commit | 14fa085640a7eb55431eec8a0273bbf0c463ce46 (patch) | |
| tree | c2e8695de33751c1a12598816a954b57fab1b67a /fs/overlayfs | |
| parent | ovl: abstract ovl_inode lock with a helper (diff) | |
| download | linux-dev-14fa085640a7eb55431eec8a0273bbf0c463ce46.tar.xz linux-dev-14fa085640a7eb55431eec8a0273bbf0c463ce46.zip | |
ovl: using posix_acl_xattr_size() to get size instead of posix_acl_to_xattr()
There is no functional change but it seems better to get size by calling
posix_acl_xattr_size() instead of calling posix_acl_to_xattr() with
NULL buffer argument. Additionally, remove unnecessary assignments.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/overlayfs')
| -rw-r--r-- | fs/overlayfs/dir.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index e03f39550ccf..ce1857fb5434 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -414,13 +414,12 @@ static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name, if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl) return 0; - size = posix_acl_to_xattr(NULL, acl, NULL, 0); + size = posix_acl_xattr_size(acl->a_count); buffer = kmalloc(size, GFP_KERNEL); if (!buffer) return -ENOMEM; - size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size); - err = size; + err = posix_acl_to_xattr(&init_user_ns, acl, buffer, size); if (err < 0) goto out_free; |