diff options
| author |   Oleg Nesterov <oleg@redhat.com> | 2014-10-09 15:25:49 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2014-10-09 22:25:49 -0400 |
| commit | 47fecca15c0944924423390fe21b956eea57da30 (patch) | |
| tree | 4844cb02728511c6d4b74b11b3781330312de2a3 /fs/proc/internal.h | |
| parent | fs/proc/task_nommu.c: shift mm_access() from m_start() to proc_maps_open() (diff) | |
| download | linux-dev-47fecca15c0944924423390fe21b956eea57da30.tar.xz linux-dev-47fecca15c0944924423390fe21b956eea57da30.zip | |
fs/proc/task_nommu.c: don't use priv->task->mm
I do not know if CONFIG_PREEMPT/SMP is possible without CONFIG_MMU
but the usage of task->mm in m_stop(). The task can exit/exec before
we take mmap_sem, in this case m_stop() can hit NULL or unlock the
wrong rw_semaphore.
Also, this code uses priv->task != NULL to decide whether we need
up_read/mmput. This is correct, but we will probably kill priv->task.
Change m_start/m_stop to rely on IS_ERR_OR_NULL() like task_mmu.c does.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/proc/internal.h')
0 files changed, 0 insertions, 0 deletions