diff options
| author |   Joel Fernandes (Google) <joel@joelfernandes.org> | 2018-11-03 16:38:18 -0700 |
|---|---|---|
| committer |   Kees Cook <keescook@chromium.org> | 2018-12-03 16:52:35 -0800 |
| commit | 30696378f68a9e3dad6bfe55938b112e72af00c2 (patch) | |
| tree | 71c33eafa0fa9dd7a969b868fd9ae3cdda86e10a /fs/pstore | |
| parent | pstore/ram: Simplify ramoops_get_next_prz() arguments (diff) | |
| download | linux-dev-30696378f68a9e3dad6bfe55938b112e72af00c2.tar.xz linux-dev-30696378f68a9e3dad6bfe55938b112e72af00c2.zip | |
pstore/ram: Do not treat empty buffers as valid
The ramoops backend currently calls persistent_ram_save_old() even
if a buffer is empty. While this appears to work, it is does not seem
like the right thing to do and could lead to future bugs so lets avoid
that. It also prevents misleading prints in the logs which claim the
buffer is valid.
I got something like:
found existing buffer, size 0, start 0
When I was expecting:
no valid data in buffer (sig = ...)
This bails out early (and reports with pr_debug()), since it's an
acceptable state.
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/pstore')
| -rw-r--r-- | fs/pstore/ram_core.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index e6375439c5ac..c11711c2cc83 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -511,6 +511,11 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig, sig ^= PERSISTENT_RAM_SIG; if (prz->buffer->sig == sig) { + if (buffer_size(prz) == 0) { + pr_debug("found existing empty buffer\n"); + return 0; + } + if (buffer_size(prz) > prz->buffer_size || buffer_start(prz) > buffer_size(prz)) { pr_info("found existing invalid buffer, size %zu, start %zu\n", |