diff options
| author |   Darrick J. Wong <djwong@kernel.org> | 2022-01-30 08:53:16 -0800 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2022-01-30 08:59:47 -0800 |
| commit | dd5532a4994bfda0386eb2286ec00758cee08444 (patch) | |
| tree | 70a8b83a527545430a10001f87c8ab47716a0dca /fs/quota | |
| parent | vfs: make sync_filesystem return errors from ->sync_fs (diff) | |
| download | linux-dev-dd5532a4994bfda0386eb2286ec00758cee08444.tar.xz linux-dev-dd5532a4994bfda0386eb2286ec00758cee08444.zip | |
quota: make dquot_quota_sync return errors from ->sync_fs
Strangely, dquot_quota_sync ignores the return code from the ->sync_fs
call, which means that quotacalls like Q_SYNC never see the error. This
doesn't seem right, so fix that.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/quota')
| -rw-r--r-- | fs/quota/dquot.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 22d904bde6ab..a74aef99bd3d 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -690,9 +690,14 @@ int dquot_quota_sync(struct super_block *sb, int type) /* This is not very clever (and fast) but currently I don't know about * any other simple way of getting quota data to disk and we must get * them there for userspace to be visible... */ - if (sb->s_op->sync_fs) - sb->s_op->sync_fs(sb, 1); - sync_blockdev(sb->s_bdev); + if (sb->s_op->sync_fs) { + ret = sb->s_op->sync_fs(sb, 1); + if (ret) + return ret; + } + ret = sync_blockdev(sb->s_bdev); + if (ret) + return ret; /* * Now when everything is written we can discard the pagecache so |