diff options
| author |   David Howells <dhowells@redhat.com> | 2009-04-23 16:41:13 +0100 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-24 13:28:31 -0700 |
| commit | 84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052 (patch) | |
| tree | 45af84d051ca760a9f9f24aa3775e5505ccd3627 /fs/romfs/super.c | |
| parent | lib: find_last_bit.o needed by a module only, move it from lib to obj (diff) | |
| download | linux-dev-84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052.tar.xz linux-dev-84baf74bf23bbe9f3deafb5d2f27e2b5dc0bc052.zip | |
ROMFS: romfs_lookup() shouldn't be doing a partial name comparison
romfs_lookup() should be using a routine akin to strcmp() on the backing store,
rather than one akin to strncmp(). If it uses the latter, it's liable to match
/bin/shutdown when looking up /bin/sh.
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/romfs/super.c')
| -rw-r--r-- | fs/romfs/super.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/romfs/super.c b/fs/romfs/super.c index 10ca7d984a8b..c53b5ef8a02f 100644 --- a/fs/romfs/super.c +++ b/fs/romfs/super.c @@ -240,8 +240,8 @@ static struct dentry *romfs_lookup(struct inode *dir, struct dentry *dentry, goto error; /* try to match the first 16 bytes of name */ - ret = romfs_dev_strncmp(dir->i_sb, offset + ROMFH_SIZE, name, - len); + ret = romfs_dev_strcmp(dir->i_sb, offset + ROMFH_SIZE, name, + len); if (ret < 0) goto error; if (ret == 1) |