diff options
| author |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-03 10:23:47 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-07 08:53:32 +0100 |
| commit | de96e9fea7ba56042f105b6fe163447b280eb800 (patch) | |
| tree | d3f6f03da38d0bbe96c587e2bae9e11cb53123ed /fs/sysfs/group.c | |
| parent | Linux 5.0-rc1 (diff) | |
| download | linux-dev-de96e9fea7ba56042f105b6fe163447b280eb800.tar.xz linux-dev-de96e9fea7ba56042f105b6fe163447b280eb800.zip | |
sysfs: convert BUG_ON to WARN_ON
It's rude to crash the system just because the developer did something
wrong, as it prevents them from usually even seeing what went wrong.
So convert the few BUG_ON() calls that have snuck into the sysfs code
over the years to WARN_ON() to make it more "friendly". All of these
are able to be recovered from, so it makes no sense to crash.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/sysfs/group.c')
| -rw-r--r-- | fs/sysfs/group.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index 1eb2d6307663..57038604d4a8 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -112,7 +112,8 @@ static int internal_create_group(struct kobject *kobj, int update, kgid_t gid; int error; - BUG_ON(!kobj || (!update && !kobj->sd)); + if (WARN_ON(!kobj || (!update && !kobj->sd))) + return -EINVAL; /* Updates may happen before the object has been instantiated */ if (unlikely(update && !kobj->sd)) |