diff options
| author |   Fabian Frederick <fabf@skynet.be> | 2017-01-06 21:54:43 +0100 |
|---|---|---|
| committer |   Jan Kara <jack@suse.cz> | 2017-01-10 11:59:21 +0100 |
| commit | 1d82a56bc5bf820b7c65d8130b44c0bc101b546c (patch) | |
| tree | 6835a6658ddb237fe19aa2d88a7ab0c5a467eb7b /fs/udf | |
| parent | udf: atomically read inode size (diff) | |
| download | linux-dev-1d82a56bc5bf820b7c65d8130b44c0bc101b546c.tar.xz linux-dev-1d82a56bc5bf820b7c65d8130b44c0bc101b546c.zip | |
udf: check partition reference in udf_read_inode()
We were checking block number without checking partition.
sbi->s_partmaps[iloc->partitionReferenceNum] could lead to
bad memory access. See udf_nfs_get_inode() path for instance.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
| -rw-r--r-- | fs/udf/inode.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 2296c8708052..8ec6b3df0bc7 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1277,6 +1277,12 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode) int ret = -EIO; reread: + if (iloc->partitionReferenceNum >= sbi->s_partitions) { + udf_debug("partition reference: %d > logical volume partitions: %d\n", + iloc->partitionReferenceNum, sbi->s_partitions); + return -EIO; + } + if (iloc->logicalBlockNum >= sbi->s_partmaps[iloc->partitionReferenceNum].s_partition_len) { udf_debug("block=%d, partition=%d out of range\n", |