diff options
| author |   Darrick J. Wong <djwong@kernel.org> | 2022-06-05 18:51:22 -0700 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2022-06-15 23:13:32 -0700 |
| commit | 10930b254d5be1cb4350fb7a456ccd5ea7e3cbd9 (patch) | |
| tree | a4ce83de600ff391f074e15d53a7ca404c3b6d3a /fs/xfs/libxfs/xfs_attr.c | |
| parent | xfs: fix TOCTOU race involving the new logged xattrs control knob (diff) | |
| download | linux-dev-10930b254d5be1cb4350fb7a456ccd5ea7e3cbd9.tar.xz linux-dev-10930b254d5be1cb4350fb7a456ccd5ea7e3cbd9.zip | |
xfs: fix variable state usage
The variable @args is fed to a tracepoint, and that's the only place
it's used. This is fine for the kernel, but for userspace, tracepoints
are #define'd out of existence, which results in this warning on gcc
11.2:
xfs_attr.c: In function ‘xfs_attr_node_try_addname’:
xfs_attr.c:1440:42: warning: unused variable ‘args’ [-Wunused-variable]
1440 | struct xfs_da_args *args = attr->xattri_da_args;
| ^~~~
Clean this up.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Diffstat (limited to 'fs/xfs/libxfs/xfs_attr.c')
| -rw-r--r-- | fs/xfs/libxfs/xfs_attr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c index 0847b4e16237..1824f61621a2 100644 --- a/fs/xfs/libxfs/xfs_attr.c +++ b/fs/xfs/libxfs/xfs_attr.c @@ -1441,12 +1441,11 @@ static int xfs_attr_node_try_addname( struct xfs_attr_intent *attr) { - struct xfs_da_args *args = attr->xattri_da_args; struct xfs_da_state *state = attr->xattri_da_state; struct xfs_da_state_blk *blk; int error; - trace_xfs_attr_node_addname(args); + trace_xfs_attr_node_addname(state->args); blk = &state->path.blk[state->path.active-1]; ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC); |