diff options
| author |   Eric Sandeen <sandeen@sandeen.net> | 2019-05-01 20:26:30 -0700 |
|---|---|---|
| committer |   Darrick J. Wong <darrick.wong@oracle.com> | 2019-05-01 20:26:30 -0700 |
| commit | 910832697cf85536c7fe26edb8bc6f830c4b9bb6 (patch) | |
| tree | 7209ecf8be203230e30b679156767e63ff88ebd1 /fs/xfs/libxfs/xfs_sb.c | |
| parent | xfs: add online scrub for superblock counters (diff) | |
| download | linux-dev-910832697cf85536c7fe26edb8bc6f830c4b9bb6.tar.xz linux-dev-910832697cf85536c7fe26edb8bc6f830c4b9bb6.zip | |
xfs: change some error-less functions to void types
There are several functions which have no opportunity to return
an error, and don't contain any ASSERTs which could be argued
to be better constructed as error cases. So, make them voids
to simplify the callers.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/libxfs/xfs_sb.c')
| -rw-r--r-- | fs/xfs/libxfs/xfs_sb.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c index 6fab49f6070b..e76a3e5d28d7 100644 --- a/fs/xfs/libxfs/xfs_sb.c +++ b/fs/xfs/libxfs/xfs_sb.c @@ -1085,7 +1085,7 @@ out: return error; } -int +void xfs_fs_geometry( struct xfs_sb *sbp, struct xfs_fsop_geom *geo, @@ -1109,13 +1109,13 @@ xfs_fs_geometry( memcpy(geo->uuid, &sbp->sb_uuid, sizeof(sbp->sb_uuid)); if (struct_version < 2) - return 0; + return; geo->sunit = sbp->sb_unit; geo->swidth = sbp->sb_width; if (struct_version < 3) - return 0; + return; geo->version = XFS_FSOP_GEOM_VERSION; geo->flags = XFS_FSOP_GEOM_FLAGS_NLINK | @@ -1159,7 +1159,7 @@ xfs_fs_geometry( geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp); if (struct_version < 4) - return 0; + return; if (xfs_sb_version_haslogv2(sbp)) geo->flags |= XFS_FSOP_GEOM_FLAGS_LOGV2; @@ -1167,11 +1167,9 @@ xfs_fs_geometry( geo->logsunit = sbp->sb_logsunit; if (struct_version < 5) - return 0; + return; geo->version = XFS_FSOP_GEOM_VERSION_V5; - - return 0; } /* Read a secondary superblock. */ |