diff options
| author |   Dave Chinner <david@fromorbit.com> | 2013-09-03 10:06:58 +1000 |
|---|---|---|
| committer |   Ben Myers <bpm@sgi.com> | 2013-09-09 17:43:58 -0500 |
| commit | 0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f (patch) | |
| tree | a5909bdca6ea1a287717d6b88dc76b4fd72f3688 /fs/xfs/xfs_btree.c | |
| parent | xfs: fix some minor sparse warnings (diff) | |
| download | linux-dev-0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f.tar.xz linux-dev-0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f.zip | |
xfs: check magic numbers in dir3 leaf verifier first
Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
validating the magic numbers in the buffer results in ASSERT
failures due to mismatching magic numbers when a corruption occurs.
Seeing as the verifier is supposed to catch the corruption and pass
it back to the caller, having the verifier assert fail on error
defeats the purpose of detecting the errors in the first place.
Check the magic numbers direct from the buffer before decoding the
header.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_btree.c')
0 files changed, 0 insertions, 0 deletions