diff options
| author |   Darrick J. Wong <darrick.wong@oracle.com> | 2018-04-17 19:10:15 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-04-17 19:10:15 -0700 |
| commit | 7b38460dc8e4eafba06c78f8e37099d3b34d473c (patch) | |
| tree | 0f5566cd5ad52f2c14fadceff90508d0504fa969 /fs/xfs/xfs_file.c | |
| parent | xfs: prevent creating negative-sized file via INSERT_RANGE (diff) | |
| download | linux-dev-7b38460dc8e4eafba06c78f8e37099d3b34d473c.tar.xz linux-dev-7b38460dc8e4eafba06c78f8e37099d3b34d473c.zip | |
xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE
Kanda Motohiro reported that expanding a tiny xattr into a large xattr
fails on XFS because we remove the tiny xattr from a shortform fork and
then try to re-add it after converting the fork to extents format having
not removed the ATTR_REPLACE flag. This fails because the attr is no
longer present, causing a fs shutdown.
This is derived from the patch in his bug report, but we really
shouldn't ignore a nonzero retval from the remove call.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199119
Reported-by: kanda.motohiro@gmail.com
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_file.c')
0 files changed, 0 insertions, 0 deletions