aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_ioctl.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2020-02-26 17:30:41 -0800
committerDarrick J. Wong <darrick.wong@oracle.com>2020-03-02 20:55:55 -0800
commit5a3930e27ef95893f039b9ec127a48139fcc8ca5 (patch)
tree9df5508abb02805575ac1b9be4a06bc59a8c0971 /fs/xfs/xfs_ioctl.c
parentxfs: lift cursor copy in/out into xfs_ioc_attr_list (diff)
downloadlinux-dev-5a3930e27ef95893f039b9ec127a48139fcc8ca5.tar.xz
linux-dev-5a3930e27ef95893f039b9ec127a48139fcc8ca5.zip
xfs: improve xfs_forget_acl
Move the function to xfs_acl.c and provide a proper stub for the !CONFIG_XFS_POSIX_ACL case. Lift the flags check to the caller as it nicely fits in there. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Chandan Rajendra <chandanrlinux@gmail.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_ioctl.c')
-rw-r--r--fs/xfs/xfs_ioctl.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 2a7d05992584..a3cd178ff0ad 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -510,8 +510,8 @@ xfs_attrmulti_attr_set(
}
error = xfs_attr_set(&args);
- if (!error)
- xfs_forget_acl(inode, name, flags);
+ if (!error && (flags & ATTR_ROOT))
+ xfs_forget_acl(inode, name);
kfree(args.value);
return error;
}