diff options
| author |   Christoph Hellwig <hch@lst.de> | 2015-04-13 11:38:29 +1000 |
|---|---|---|
| committer |   Dave Chinner <david@fromorbit.com> | 2015-04-13 11:38:29 +1000 |
| commit | 21c3ea18819b5f650c75f59a0457415bc05d2b17 (patch) | |
| tree | 4a6ffaa3bed47bc57441c3ffe9d2f1e55a8b197d /fs/xfs/xfs_pnfs.c | |
| parent | xfs: kill unnecessary firstused overflow check on attr3 leaf removal (diff) | |
| download | linux-dev-21c3ea18819b5f650c75f59a0457415bc05d2b17.tar.xz linux-dev-21c3ea18819b5f650c75f59a0457415bc05d2b17.zip | |
xfs: unlock i_mutex in xfs_break_layouts
We want to drop all I/O path locks when recalling layouts, and that includes
i_mutex for the write path. Without this we get stuck processe when recalls
take too long.
[dchinner: fix build with !CONFIG_PNFS]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/xfs_pnfs.c')
| -rw-r--r-- | fs/xfs/xfs_pnfs.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c index 4b33ef112400..cbb424f4d93a 100644 --- a/fs/xfs/xfs_pnfs.c +++ b/fs/xfs/xfs_pnfs.c @@ -31,7 +31,8 @@ int xfs_break_layouts( struct inode *inode, - uint *iolock) + uint *iolock, + bool with_imutex) { struct xfs_inode *ip = XFS_I(inode); int error; @@ -40,8 +41,12 @@ xfs_break_layouts( while ((error = break_layout(inode, false) == -EWOULDBLOCK)) { xfs_iunlock(ip, *iolock); + if (with_imutex && (*iolock & XFS_IOLOCK_EXCL)) + mutex_unlock(&inode->i_mutex); error = break_layout(inode, true); *iolock = XFS_IOLOCK_EXCL; + if (with_imutex) + mutex_lock(&inode->i_mutex); xfs_ilock(ip, *iolock); } |