diff options
| author |   Jan Kara <jack@suse.com> | 2015-08-25 10:05:13 +1000 |
|---|---|---|
| committer |   Dave Chinner <david@fromorbit.com> | 2015-08-25 10:05:13 +1000 |
| commit | c184f855c483428027d6ec937e4a9d5f15b2cbad (patch) | |
| tree | 9c8e9d0c92b5479abe523ff1a2dd862039213986 /fs/xfs | |
| parent | xfs: inode lockdep annotations broke non-lockdep build (diff) | |
| download | linux-dev-c184f855c483428027d6ec937e4a9d5f15b2cbad.tar.xz linux-dev-c184f855c483428027d6ec937e4a9d5f15b2cbad.zip | |
xfs: Fix uninitialized return value in xfs_alloc_fix_freelist()
xfs_alloc_fix_freelist() can sometimes jump to out_agbp_relse
without ever setting value of 'error' variable which is then
returned. This can happen e.g. when pag->pagf_init is set but AG is
for metadata and we want to allocate user data.
Fix the problem by initializing 'error' to 0, which is the desired
return value when we decide to skip this group.
CC: xfs@oss.sgi.com
Coverity-id: 1309714
Signed-off-by: Jan Kara <jack@suse.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/libxfs/xfs_alloc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c index b7fc17ce8233..ffad7f20342f 100644 --- a/fs/xfs/libxfs/xfs_alloc.c +++ b/fs/xfs/libxfs/xfs_alloc.c @@ -1937,7 +1937,7 @@ xfs_alloc_fix_freelist( struct xfs_alloc_arg targs; /* local allocation arguments */ xfs_agblock_t bno; /* freelist block */ xfs_extlen_t need; /* total blocks needed in freelist */ - int error; + int error = 0; if (!pag->pagf_init) { error = xfs_alloc_read_agf(mp, tp, args->agno, flags, &agbp); |