diff options
| author |   Eric Sesterhenn <snakebyte@gmx.de> | 2006-04-01 01:14:43 +0200 |
|---|---|---|
| committer |   Adrian Bunk <bunk@stusta.de> | 2006-04-01 01:14:43 +0200 |
| commit | 0bf3ba538a150f8430104a50e88c1449e8fa1fe6 (patch) | |
| tree | a44fc8bb4804ff132449f4ab96e0ed72bf836dda /fs | |
| parent | BUG_ON() Conversion in fs/exec.c (diff) | |
| download | linux-dev-0bf3ba538a150f8430104a50e88c1449e8fa1fe6.tar.xz linux-dev-0bf3ba538a150f8430104a50e88c1449e8fa1fe6.zip | |
BUG_ON() Conversion in fs/hfsplus/
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/hfsplus/bnode.c | 6 | ||||
| -rw-r--r-- | fs/hfsplus/btree.c | 3 |
2 files changed, 3 insertions, 6 deletions
diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index 8f07e8fbd03d..746abc9ecf70 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -466,8 +466,7 @@ void hfs_bnode_unhash(struct hfs_bnode *node) for (p = &node->tree->node_hash[hfs_bnode_hash(node->this)]; *p && *p != node; p = &(*p)->next_hash) ; - if (!*p) - BUG(); + BUG_ON(!*p); *p = node->next_hash; node->tree->node_hash_cnt--; } @@ -622,8 +621,7 @@ void hfs_bnode_put(struct hfs_bnode *node) dprint(DBG_BNODE_REFS, "put_node(%d:%d): %d\n", node->tree->cnid, node->this, atomic_read(&node->refcnt)); - if (!atomic_read(&node->refcnt)) - BUG(); + BUG_ON(!atomic_read(&node->refcnt)); if (!atomic_dec_and_lock(&node->refcnt, &tree->hash_lock)) return; for (i = 0; i < tree->pages_per_bnode; i++) { diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c index a67edfa34e9e..effa8991999c 100644 --- a/fs/hfsplus/btree.c +++ b/fs/hfsplus/btree.c @@ -269,8 +269,7 @@ void hfs_bmap_free(struct hfs_bnode *node) u8 *data, byte, m; dprint(DBG_BNODE_MOD, "btree_free_node: %u\n", node->this); - if (!node->this) - BUG(); + BUG_ON(!node->this); tree = node->tree; nidx = node->this; node = hfs_bnode_find(tree, 0); |